From: Shawn Guo <shawn.guo@linaro.org>
Date: Fri, 15 Jul 2011 09:25:28 +0000 (+0800)
Subject: dmaengine: imx-sdma: sdma_get_firmware does not need to copy fw_name
X-Git-Tag: MMI-PSA29.97-13-9~18738^2^2~1
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=40ad5b37914368a4f2c5ff1e72712375d6f1188b;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

dmaengine: imx-sdma: sdma_get_firmware does not need to copy fw_name

It does not need to allocate space and copy fw_name in function
sdma_get_firmware().

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Vinod Koul <vinod.koul@intel.com>
---

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index a7708b481eab..df400691f9a0 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1126,22 +1126,14 @@ static int __init sdma_get_firmware(struct sdma_engine *sdma,
 		const char *fw_name)
 {
 	const struct firmware *fw;
-	char *fwname;
 	const struct sdma_firmware_header *header;
 	int ret;
 	const struct sdma_script_start_addrs *addr;
 	unsigned short *ram_code;
 
-	fwname = kasprintf(GFP_KERNEL, "%s", fw_name);
-	if (!fwname)
-		return -ENOMEM;
-
-	ret = request_firmware(&fw, fwname, sdma->dev);
-	if (ret) {
-		kfree(fwname);
+	ret = request_firmware(&fw, fw_name, sdma->dev);
+	if (ret)
 		return ret;
-	}
-	kfree(fwname);
 
 	if (fw->size < sizeof(*header))
 		goto err_firmware;