From: Chao Yu Date: Wed, 5 Sep 2018 06:54:02 +0000 (+0800) Subject: f2fs: fix memory leak of percpu counter in fill_super() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=407d6a66cbcc266114eefcc7bcc56d9b07878130;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git f2fs: fix memory leak of percpu counter in fill_super() In fill_super -> init_percpu_info, we should destroy percpu counter in error path, otherwise memory allcoated for percpu counter will leak. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index bd8956692e12..f321b99a72a7 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -2458,8 +2458,12 @@ static int init_percpu_info(struct f2fs_sb_info *sbi) if (err) return err; - return percpu_counter_init(&sbi->total_valid_inode_count, 0, + err = percpu_counter_init(&sbi->total_valid_inode_count, 0, GFP_KERNEL); + if (err) + percpu_counter_destroy(&sbi->alloc_valid_block_count); + + return err; } #ifdef CONFIG_BLK_DEV_ZONED