From: Markus Elfring Date: Thu, 9 Feb 2017 14:30:53 +0000 (+0100) Subject: IB/hfi1: Use kcalloc() in hfi1_user_exp_rcv_init() X-Git-Tag: MMI-PSA29.97-13-9~5649^3~153 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=4076e5187ddc2aac7b66c72c3cb365aeee1f8b28;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git IB/hfi1: Use kcalloc() in hfi1_user_exp_rcv_init() * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring Signed-off-by: Doug Ledford --- diff --git a/drivers/infiniband/hw/hfi1/user_exp_rcv.c b/drivers/infiniband/hw/hfi1/user_exp_rcv.c index 25a8698f7db9..002214eef472 100644 --- a/drivers/infiniband/hw/hfi1/user_exp_rcv.c +++ b/drivers/infiniband/hw/hfi1/user_exp_rcv.c @@ -200,8 +200,9 @@ int hfi1_user_exp_rcv_init(struct file *fp) if (!HFI1_CAP_UGET_MASK(uctxt->flags, TID_UNMAP)) { fd->invalid_tid_idx = 0; - fd->invalid_tids = kzalloc(uctxt->expected_count * - sizeof(u32), GFP_KERNEL); + fd->invalid_tids = kcalloc(uctxt->expected_count, + sizeof(*fd->invalid_tids), + GFP_KERNEL); if (!fd->invalid_tids) { ret = -ENOMEM; goto done;