From: Tomasz Bursztyka Date: Thu, 28 Jun 2012 02:57:49 +0000 (+0000) Subject: netfilter: nfnetlink: fix missing rcu_read_unlock in nfnetlink_rcv_msg X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=4009e18851ea555959c6017d848983b3d60bf667;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git netfilter: nfnetlink: fix missing rcu_read_unlock in nfnetlink_rcv_msg Bug added in commit 6b75e3e8d664a9a (netfilter: nfnetlink: add RCU in nfnetlink_rcv_msg()) Signed-off-by: Tomasz Bursztyka Acked-by: Eric Dumazet Signed-off-by: Pablo Neira Ayuso --- diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c index 3e797d1fcb94..791d56bbd74a 100644 --- a/net/netfilter/nfnetlink.c +++ b/net/netfilter/nfnetlink.c @@ -169,8 +169,10 @@ replay: err = nla_parse(cda, ss->cb[cb_id].attr_count, attr, attrlen, ss->cb[cb_id].policy); - if (err < 0) + if (err < 0) { + rcu_read_unlock(); return err; + } if (nc->call_rcu) { err = nc->call_rcu(net->nfnl, skb, nlh,