From: Chris Packham Date: Wed, 7 Jun 2017 21:55:30 +0000 (+1200) Subject: EDAC, mv64x60: Sanity check edac_op_state before registering X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=3b405e30cbcac3aa327ae04a29e7da5d084a4933;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git EDAC, mv64x60: Sanity check edac_op_state before registering edac_op_state is a module parameter which affects the behaviour of the driver probe which can potentially be invoked as soon as the platform driver registration happens. Because of this we need to ensure that we sanity check the module parameter before calling platform_register_drivers(). Signed-off-by: Chris Packham Cc: linux-edac Link: http://lkml.kernel.org/r/20170607215530.8604-1-chris.packham@alliedtelesis.co.nz Signed-off-by: Borislav Petkov --- diff --git a/drivers/edac/mv64x60_edac.c b/drivers/edac/mv64x60_edac.c index 77bfc3d882a8..d3650df94fe8 100644 --- a/drivers/edac/mv64x60_edac.c +++ b/drivers/edac/mv64x60_edac.c @@ -853,11 +853,6 @@ static struct platform_driver * const drivers[] = { static int __init mv64x60_edac_init(void) { - int ret; - - ret = platform_register_drivers(drivers, ARRAY_SIZE(drivers)); - if (ret) - return ret; printk(KERN_INFO "Marvell MV64x60 EDAC driver " MV64x60_REVISION "\n"); printk(KERN_INFO "\t(C) 2006-2007 MontaVista Software\n"); @@ -872,7 +867,7 @@ static int __init mv64x60_edac_init(void) break; } - return 0; + return platform_register_drivers(drivers, ARRAY_SIZE(drivers)); } module_init(mv64x60_edac_init);