From: Samuel Ortiz Date: Tue, 5 Oct 2010 23:03:12 +0000 (+0200) Subject: irda: Fix heap memory corruption in iriap.c X-Git-Tag: MMI-PSA29.97-13-9~21994^2~170 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=37f9fc452d138dfc4da2ee1ce5ae85094efc3606;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git irda: Fix heap memory corruption in iriap.c While parsing the GetValuebyClass command frame, we could potentially write passed the skb->data pointer. Cc: stable@kernel.org Reported-by: Ilja Van Sprundel Signed-off-by: Samuel Ortiz --- diff --git a/net/irda/iriap.c b/net/irda/iriap.c index fce364c6c71a..5b743bdd89ba 100644 --- a/net/irda/iriap.c +++ b/net/irda/iriap.c @@ -502,7 +502,8 @@ static void iriap_getvaluebyclass_confirm(struct iriap_cb *self, IRDA_DEBUG(4, "%s(), strlen=%d\n", __func__, value_len); /* Make sure the string is null-terminated */ - fp[n+value_len] = 0x00; + if (n + value_len < skb->len) + fp[n + value_len] = 0x00; IRDA_DEBUG(4, "Got string %s\n", fp+n); /* Will truncate to IAS_MAX_STRING bytes */