From: Julia Lawall Date: Mon, 22 Dec 2008 21:53:40 +0000 (+0000) Subject: [CIFS] Remove redundant test X-Git-Tag: MMI-PSA29.97-13-9~30475^2 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=359d67d6ad054ae11ad459665fdfb883aca87782;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git [CIFS] Remove redundant test In fs/cifs/cifssmb.c, pLockData is tested for being NULL at the beginning of the function, and not reassigned subsequently. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) Signed-off-by: Julia Lawall Signed-off-by: Steve French --- diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 824df142f288..552642a507c4 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -1871,10 +1871,6 @@ CIFSSMBPosixLock(const int xid, struct cifsTconInfo *tcon, rc = -EIO; /* bad smb */ goto plk_err_exit; } - if (pLockData == NULL) { - rc = -EINVAL; - goto plk_err_exit; - } data_offset = le16_to_cpu(pSMBr->t2.DataOffset); data_count = le16_to_cpu(pSMBr->t2.DataCount); if (data_count < sizeof(struct cifs_posix_lock)) {