From: Gustavo A. R. Silva Date: Wed, 9 Aug 2017 15:46:48 +0000 (-0500) Subject: spi: spi-sh: fix error return code in spi_sh_probe() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=345fef75d7c55e63f7a109f7a26ff35718c5f028;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git spi: spi-sh: fix error return code in spi_sh_probe() platform_get_irq() returns an error code, but the spi-sh driver ignores it and always returns -ENODEV. This is not correct and, prevents -EPROBE_DEFER from being propagated properly. Print and propagate the return value of platform_get_irq on failure. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-sh.c b/drivers/spi/spi-sh.c index 2bf53f0e27d9..50e0ea9acf8b 100644 --- a/drivers/spi/spi-sh.c +++ b/drivers/spi/spi-sh.c @@ -446,8 +446,8 @@ static int spi_sh_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(&pdev->dev, "platform_get_irq error\n"); - return -ENODEV; + dev_err(&pdev->dev, "platform_get_irq error: %d\n", irq); + return irq; } master = spi_alloc_master(&pdev->dev, sizeof(struct spi_sh_data));