From: Julia Lawall Date: Wed, 23 Sep 2009 22:57:36 +0000 (-0700) Subject: drivers/vlynq/vlynq.c: fix resource size off by 1 error X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=3354f73b24c6d392ed7fd5583cfcc7604c1934ae;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git drivers/vlynq/vlynq.c: fix resource size off by 1 error In this case, the calls to request_mem_region, ioremap, and release_mem_region all have a consistent length argument, len, but since in other files (res->end - res->start) + 1, equivalent to resource_size(res), is used for a resource-typed structure res, one could consider whether the same should be done here. The problem was found using the following semantic patch: (http://www.emn.fr/x-info/coccinelle/) // @@ struct resource *res; @@ - (res->end - res->start) + 1 + resource_size(res) @@ struct resource *res; @@ - res->end - res->start + BAD(resource_size(res)) // Signed-off-by: Julia Lawall Acked-by: Florian Fainelli Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c index ba3d71f5c7d0..9554ad5f9af7 100644 --- a/drivers/vlynq/vlynq.c +++ b/drivers/vlynq/vlynq.c @@ -702,7 +702,7 @@ static int vlynq_probe(struct platform_device *pdev) dev->mem_start = mem_res->start; dev->mem_end = mem_res->end; - len = regs_res->end - regs_res->start; + len = resource_size(regs_res); if (!request_mem_region(regs_res->start, len, dev_name(&dev->dev))) { printk(KERN_ERR "%s: Can't request vlynq registers\n", dev_name(&dev->dev));