From: Amerigo Wang <amwang@redhat.com>
Date: Fri, 10 Aug 2012 01:24:39 +0000 (+0000)
Subject: netconsole: do not release spin_lock when calling __netpoll_cleanup
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=3335f0ca130c201f8680e97f63612053fbc16e22;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git

netconsole: do not release spin_lock when calling __netpoll_cleanup

With the previous patch applied, __netpoll_cleanup() is non-block now,
so we don't need to release the spin_lock before calling it.

Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index f9347ea3d38..f0ad56c1393 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -640,12 +640,7 @@ static int netconsole_netdev_event(struct notifier_block *this,
 				 * rtnl_lock already held
 				 */
 				if (nt->np.dev) {
-					spin_unlock_irqrestore(
-							      &target_list_lock,
-							      flags);
 					__netpoll_cleanup(&nt->np);
-					spin_lock_irqsave(&target_list_lock,
-							  flags);
 					dev_put(nt->np.dev);
 					nt->np.dev = NULL;
 					netconsole_target_put(nt);