From: Alexander Ebert <ebert@woltlab.com>
Date: Thu, 28 Nov 2019 21:40:59 +0000 (+0100)
Subject: Prevent system-type pages from being copied
X-Git-Tag: 5.2.0_Beta_4~6
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=32e2526706494200a7a8e45ae59a3170979a7a88;p=GitHub%2FWoltLab%2FWCF.git

Prevent system-type pages from being copied
---

diff --git a/wcfsetup/install/files/acp/templates/pageAdd.tpl b/wcfsetup/install/files/acp/templates/pageAdd.tpl
index 8e2aedf873..d7f4c53b97 100644
--- a/wcfsetup/install/files/acp/templates/pageAdd.tpl
+++ b/wcfsetup/install/files/acp/templates/pageAdd.tpl
@@ -50,7 +50,7 @@
 			{/if}
 		});
 	</script>
-{else}
+{elseif $page->pageType !== 'system'}
 	<script data-relocate="true">
 		require(['Language', 'WoltLabSuite/Core/Acp/Ui/Page/Copy'], function (Language, AcpUiPageCopy) {
 			Language.addObject({
@@ -79,7 +79,9 @@
 	<nav class="contentHeaderNavigation">
 		<ul>
 			{if $action == 'edit'}
-				<li><a href="#" class="button jsButtonCopyPage"><span class="icon icon16 fa-copy"></span> {lang}wcf.acp.page.button.copyPage{/lang}</a></li>
+				{if $page->pageType !== 'system'}
+					<li><a href="#" class="button jsButtonCopyPage"><span class="icon icon16 fa-copy"></span> {lang}wcf.acp.page.button.copyPage{/lang}</a></li>
+				{/if}
 				
 				{if !$page->requireObjectID}
 					<li><a href="{$page->getLink()}" class="button"><span class="icon icon16 fa-search"></span> <span>{lang}wcf.acp.page.button.viewPage{/lang}</span></a></li>
diff --git a/wcfsetup/install/files/lib/acp/form/PageAddForm.class.php b/wcfsetup/install/files/lib/acp/form/PageAddForm.class.php
index d970bd2e5d..1cdac321f9 100644
--- a/wcfsetup/install/files/lib/acp/form/PageAddForm.class.php
+++ b/wcfsetup/install/files/lib/acp/form/PageAddForm.class.php
@@ -234,7 +234,7 @@ class PageAddForm extends AbstractForm {
 		if (isset($_GET['presetPageID'])) $this->presetPageID = intval($_GET['presetPageID']);
 		if ($this->presetPageID) {
 			$this->presetPage = new Page($this->presetPageID);
-			if (!$this->presetPage->pageID) {
+			if (!$this->presetPage->pageID || $this->presetPage->pageType === 'system') {
 				throw new IllegalLinkException();
 			}
 		}