From: Sasha Levin Date: Thu, 7 Jan 2016 19:52:43 +0000 (-0500) Subject: net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=320f1a4a175e7cd5d3f006f92b4d4d3e2cbb7bb5;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory proc_dostring() needs an initialized destination string, while the one provided in proc_sctp_do_hmac_alg() contains stack garbage. Thus, writing to cookie_hmac_alg would strlen() that garbage and end up accessing invalid memory. Fixes: 3c68198e7 ("sctp: Make hmac algorithm selection for cookie generation dynamic") Signed-off-by: Sasha Levin Signed-off-by: David S. Miller --- diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c index 26d50c565f54..3e0fc5127225 100644 --- a/net/sctp/sysctl.c +++ b/net/sctp/sysctl.c @@ -320,7 +320,7 @@ static int proc_sctp_do_hmac_alg(struct ctl_table *ctl, int write, struct ctl_table tbl; bool changed = false; char *none = "none"; - char tmp[8]; + char tmp[8] = {0}; int ret; memset(&tbl, 0, sizeof(struct ctl_table));