From: Wolfram Sang Date: Thu, 3 Sep 2015 20:20:10 +0000 (+0200) Subject: i2c: rcar: don't issue stop when HW does it automatically X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=315a1736a2f2d9ad21dddea6bed766469342c2dc;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git i2c: rcar: don't issue stop when HW does it automatically The manual says (55.4.8.6) that HW does automatically send STOP after NACK was received. My measuerments confirm that. Signed-off-by: Wolfram Sang Signed-off-by: Wolfram Sang --- diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 36c79301044b..dcf9fc77cec7 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -458,8 +458,8 @@ static irqreturn_t rcar_i2c_irq(int irq, void *ptr) /* Nack */ if (msr & MNR) { - /* go to stop phase */ - rcar_i2c_write(priv, ICMCR, RCAR_BUS_PHASE_STOP); + /* HW automatically sends STOP after received NACK */ + rcar_i2c_write(priv, ICMCR, RCAR_BUS_PHASE_DATA); rcar_i2c_write(priv, ICMIER, RCAR_IRQ_STOP); rcar_i2c_flags_set(priv, ID_NACK); goto out;