From: Julia Lawall <julia@diku.dk>
Date: Mon, 16 Aug 2010 16:27:47 +0000 (-0300)
Subject: V4L/DVB: drivers/media/video: Use available error codes
X-Git-Tag: MMI-PSA29.97-13-9~21911^2~471
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=3053814c1cbedb9d2802240f414588009706c74d;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

V4L/DVB: drivers/media/video: Use available error codes

Error codes are stored in rc, but the return value is always 0.  Return rc
instead.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
local idexpression x;
constant C;
@@

if (...) { ...
  x = -C
  ... when != x
(
  return <+...x...+>;
|
  return NULL;
|
  return;
|
* return ...;
)
}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/video/zr364xx.c b/drivers/media/video/zr364xx.c
index a82b5bd18d26..616c61fb3493 100644
--- a/drivers/media/video/zr364xx.c
+++ b/drivers/media/video/zr364xx.c
@@ -572,7 +572,7 @@ static int zr364xx_got_frame(struct zr364xx_camera *cam, int jpgsize)
 	DBG("wakeup [buf/i] [%p/%d]\n", buf, buf->vb.i);
 unlock:
 	spin_unlock_irqrestore(&cam->slock, flags);
-	return 0;
+	return rc;
 }
 
 /* this function moves the usb stream read pipe data