From: Petr Matousek <pmatouse@redhat.com>
Date: Wed, 11 Mar 2015 11:16:09 +0000 (+0100)
Subject: kvm: x86: i8259: return initialized data on invalid-size read
X-Git-Tag: MMI-PSA29.97-13-9~10342^2~29
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=2dccb4cdbf8fd4cb1d779a6f7ddd66d193bb5805;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

kvm: x86: i8259: return initialized data on invalid-size read

If data is read from PIC with invalid access size, the return data stays
uninitialized even though success is returned.

Fix this by always initializing the data.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Nadav Amit <nadav.amit@gmail.com>
Message-Id: <20150311111609.GG8544@dhcp-25-225.brq.redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c
index cc31f7c06d3d..9541ba34126b 100644
--- a/arch/x86/kvm/i8259.c
+++ b/arch/x86/kvm/i8259.c
@@ -507,6 +507,7 @@ static int picdev_read(struct kvm_pic *s,
 		return -EOPNOTSUPP;
 
 	if (len != 1) {
+		memset(val, 0, len);
 		pr_pic_unimpl("non byte read\n");
 		return 0;
 	}