From: yizhouzhou@ict.ac.cn Date: Fri, 23 Sep 2016 14:06:00 +0000 (+0200) Subject: cris: return of class_create should be considered X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=2dc024e94578c53e2c579a48725c8fe2527f9d5e;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git cris: return of class_create should be considered Return value of class_create should be considered in module init function. Signed-off-by: Zhouyi Zhou Signed-off-by: Jesper Nilsson --- diff --git a/arch/cris/arch-v32/drivers/sync_serial.c b/arch/cris/arch-v32/drivers/sync_serial.c index e989cee77414..ef515af1a377 100644 --- a/arch/cris/arch-v32/drivers/sync_serial.c +++ b/arch/cris/arch-v32/drivers/sync_serial.c @@ -1627,6 +1627,12 @@ static int __init etrax_sync_serial_init(void) /* Create a sysfs class for syncser */ syncser_class = class_create(THIS_MODULE, "syncser_class"); + if (IS_ERR(syncser_class)) { + pr_err("Failed to create a sysfs class for syncser\n"); + unregister_chrdev_region(syncser_first, minor_count); + cdev_del(syncser_cdev); + return -1; + } /* Initialize Ports */ #if defined(CONFIG_ETRAX_SYNCHRONOUS_SERIAL_PORT0)