From: Dan Carpenter Date: Sun, 15 Jan 2012 11:29:39 +0000 (+0300) Subject: staging: precedence bug in crystalhd_stop_tx_dma_engine() X-Git-Tag: MMI-PSA29.97-13-9~17268^2~176^2~103 X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=2da57c8e4ac0933417f9fdd141bf5bebc87edc1e;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git staging: precedence bug in crystalhd_stop_tx_dma_engine() The intent here is to see if we have cleared the DMA_START_BIT flag. We clear it a couple lines later. The current code has a precedence bug so it is equivalent to "if (!dma_cntrl) { ...". Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/crystalhd/crystalhd_hw.c b/drivers/staging/crystalhd/crystalhd_hw.c index 5acf39e7cdef..eeddee9a6050 100644 --- a/drivers/staging/crystalhd/crystalhd_hw.c +++ b/drivers/staging/crystalhd/crystalhd_hw.c @@ -868,8 +868,7 @@ static enum BC_STATUS crystalhd_stop_tx_dma_engine(struct crystalhd_hw *hw) BCMLOG(BCMLOG_DBG, "Stopping TX DMA Engine..\n"); - /* FIXME: jarod: invert dma_ctrl and check bit? or are there missing parens? */ - if (!dma_cntrl & DMA_START_BIT) { + if (!(dma_cntrl & DMA_START_BIT)) { BCMLOG(BCMLOG_DBG, "Already Stopped\n"); return BC_STS_SUCCESS; }