From: Steven Whitehouse Date: Wed, 7 Feb 2007 15:25:59 +0000 (-0500) Subject: [GFS2] Unlock page on prepare_write try lock failure X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=2d72e7101cc7fff5c1eb21bfcbba51c8002418d2;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git [GFS2] Unlock page on prepare_write try lock failure When the try lock of the glock failed in prepare_write we were incorrectly exiting this function with the page still locked. This was resulting in further I/O to this page hanging. Signed-off-by: Steven Whitehouse --- diff --git a/fs/gfs2/ops_address.c b/fs/gfs2/ops_address.c index 9ddf9753a552..5e9653c4d886 100644 --- a/fs/gfs2/ops_address.c +++ b/fs/gfs2/ops_address.c @@ -360,8 +360,10 @@ static int gfs2_prepare_write(struct file *file, struct page *page, gfs2_holder_init(ip->i_gl, LM_ST_EXCLUSIVE, GL_ATIME|LM_FLAG_TRY_1CB, &ip->i_gh); error = gfs2_glock_nq_atime(&ip->i_gh); if (unlikely(error)) { - if (error == GLR_TRYFAILED) + if (error == GLR_TRYFAILED) { + unlock_page(page); error = AOP_TRUNCATED_PAGE; + } goto out_uninit; }