From: Aishwarya Pant Date: Fri, 10 Mar 2017 16:39:27 +0000 (+0530) Subject: staging: bcm2835-camera: remove anonymous field declarations X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=2ba835dd3e0457bd81662570d49e4123851fe159;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git staging: bcm2835-camera: remove anonymous field declarations Anonymous field declarations are error prone. This patch replaces anonymous declarations with explicit field declarations for typedef SERVICE_CREATION_T in vchiq_mmal_init(..) Signed-off-by: Aishwarya Pant Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c index 803095ee6c85..88b379f52e0b 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c @@ -1977,16 +1977,16 @@ int vchiq_mmal_init(struct vchiq_mmal_instance **out_instance) static VCHI_CONNECTION_T *vchi_connection; static VCHI_INSTANCE_T vchi_instance; SERVICE_CREATION_T params = { - VCHI_VERSION_EX(VC_MMAL_VER, VC_MMAL_MIN_VER), - VC_MMAL_SERVER_NAME, - vchi_connection, - 0, /* rx fifo size (unused) */ - 0, /* tx fifo size (unused) */ - service_callback, - NULL, /* service callback parameter */ - 1, /* unaligned bulk receives */ - 1, /* unaligned bulk transmits */ - 0 /* want crc check on bulk transfers */ + .version = VCHI_VERSION_EX(VC_MMAL_VER, VC_MMAL_MIN_VER), + .service_id = VC_MMAL_SERVER_NAME, + .connection = vchi_connection, + .rx_fifo_size = 0, + .tx_fifo_size = 0, + .callback = service_callback, + .callback_param = NULL, + .want_unaligned_bulk_rx = 1, + .want_unaligned_bulk_tx = 1, + .want_crc = 0 }; /* compile time checks to ensure structure size as they are