From: Simon Wood Date: Fri, 15 Aug 2014 02:43:01 +0000 (-0600) Subject: HID: logitech: Prevent possibility of infinite loop when using /sys interface X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=29ff66571d38f01c5a5d3af871401b8a65323422;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git HID: logitech: Prevent possibility of infinite loop when using /sys interface If the device data is not accessible for some reason, returning 0 will cause the call to be continuously called again as none of the string has been 'consumed'. Signed-off-by: Simon Wood Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c index cc2bd2022198..7835717bc020 100644 --- a/drivers/hid/hid-lg4ff.c +++ b/drivers/hid/hid-lg4ff.c @@ -451,13 +451,13 @@ static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *at drv_data = hid_get_drvdata(hid); if (!drv_data) { hid_err(hid, "Private driver data not found!\n"); - return 0; + return -EINVAL; } entry = drv_data->device_props; if (!entry) { hid_err(hid, "Device properties not found!\n"); - return 0; + return -EINVAL; } if (range == 0)