From: Mandeep Singh Baines <msb@chromium.org>
Date: Thu, 15 Dec 2011 22:21:26 +0000 (-0800)
Subject: cgroups: remove redundant get/put of css_set from css_set_check_fetched()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=29e21368b9baf9c4b25060d65062da2dda926c70;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git

cgroups: remove redundant get/put of css_set from css_set_check_fetched()

We already have a reference to all elements in newcg_list.

Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: containers@lists.linux-foundation.org
Cc: cgroups@vger.kernel.org
Cc: Paul Menage <paul@paulmenage.org>
---

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 1b3b84174ea..bc3caff138d 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -2025,23 +2025,17 @@ static bool css_set_check_fetched(struct cgroup *cgrp,
 
 	read_lock(&css_set_lock);
 	newcg = find_existing_css_set(cg, cgrp, template);
-	if (newcg)
-		get_css_set(newcg);
 	read_unlock(&css_set_lock);
 
 	/* doesn't exist at all? */
 	if (!newcg)
 		return false;
 	/* see if it's already in the list */
-	list_for_each_entry(cg_entry, newcg_list, links) {
-		if (cg_entry->cg == newcg) {
-			put_css_set(newcg);
+	list_for_each_entry(cg_entry, newcg_list, links)
+		if (cg_entry->cg == newcg)
 			return true;
-		}
-	}
 
 	/* not found */
-	put_css_set(newcg);
 	return false;
 }