From: Julia Lawall <julia@diku.dk>
Date: Sun, 5 Sep 2010 09:00:21 +0000 (+0000)
Subject: net/9p/trans_fd.c: Fix unsigned return type
X-Git-Tag: MMI-PSA29.97-13-9~21994^2~537
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=29af9309dba25077f711f5f975977714bc43a0c3;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

net/9p/trans_fd.c: Fix unsigned return type

The function has an unsigned return type, but returns a negative constant
to indicate an error condition.  The result of calling the function is
always stored in a variable of type (signed) int, and thus unsigned can be
dropped from the return type.

A sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@exists@
identifier f;
constant C;
@@

 unsigned f(...)
 { <+...
*  return -C;
 ...+> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index c85109d809ca..078eb162d9bf 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -222,7 +222,7 @@ static void p9_conn_cancel(struct p9_conn *m, int err)
 	}
 }
 
-static unsigned int
+static int
 p9_fd_poll(struct p9_client *client, struct poll_table_struct *pt)
 {
 	int ret, n;