From: Diego Liziero <diegoliz@gmail.com>
Date: Tue, 14 Apr 2009 02:33:54 +0000 (+0200)
Subject: Staging winbond: boolean negation and bitwise operation in wrong order
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=290d4c23506545633878132860cc7d4fac0da23e;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git

Staging winbond: boolean negation and bitwise operation in wrong order

The semantic patch that makes this change is:
(http://www.emn.fr/x-info/coccinelle/)

@@ expression E; constant C; @@
(
- !E == C
+ E != C
)

Signed-off-by: Diego Liziero <diegoliz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c
index c7af09257e6f..59d6d67a9f7e 100644
--- a/drivers/staging/winbond/mds.c
+++ b/drivers/staging/winbond/mds.c
@@ -432,7 +432,7 @@ Mds_Tx(struct wbsoft_priv * adapter)
 		return;
 
 	//Only one thread can be run here
-	if (!atomic_inc_return(&pMds->TxThreadCount) == 1)
+	if (atomic_inc_return(&pMds->TxThreadCount) != 1)
 		goto cleanup;
 
 	// Start to fill the data