From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 18 Apr 2011 00:52:51 +0000 (-0700)
Subject: bridge: fix accidental creation of sysfs directory
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=28674b97cfb907b0b3de7b7fea89efda1e65f34e;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git

bridge: fix accidental creation of sysfs directory

Commit bb900b27a2f49b37bc38c08e656ea13048fee13b ("bridge: allow
creating bridge devices with netlink") introduced a bug in net-next
because of a typo in notifier. Every device would have the sysfs
bridge directory (and files).

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/bridge/br_notify.c b/net/bridge/br_notify.c
index 7a03bb975375..606b323e8a0c 100644
--- a/net/bridge/br_notify.c
+++ b/net/bridge/br_notify.c
@@ -37,7 +37,7 @@ static int br_device_event(struct notifier_block *unused, unsigned long event, v
 	int err;
 
 	/* register of bridge completed, add sysfs entries */
-	if ((dev->priv_flags && IFF_EBRIDGE) && event == NETDEV_REGISTER) {
+	if ((dev->priv_flags & IFF_EBRIDGE) && event == NETDEV_REGISTER) {
 		br_sysfs_addbr(dev);
 		return NOTIFY_DONE;
 	}