From: J. Bruce Fields <bfields@redhat.com>
Date: Thu, 8 May 2014 15:19:41 +0000 (-0400)
Subject: nfsd4: warn on finding lockowner without stateid's
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=27b11428b7de097c42f205beabb1764f4365443b;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

nfsd4: warn on finding lockowner without stateid's

The current code assumes a one-to-one lockowner<->lock stateid
correspondance.

Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 89e42409b237..9a77a5a21557 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -4166,6 +4166,10 @@ static bool same_lockowner_ino(struct nfs4_lockowner *lo, struct inode *inode, c
 
 	if (!same_owner_str(&lo->lo_owner, owner, clid))
 		return false;
+	if (list_empty(&lo->lo_owner.so_stateids)) {
+		WARN_ON_ONCE(1);
+		return false;
+	}
 	lst = list_first_entry(&lo->lo_owner.so_stateids,
 			       struct nfs4_ol_stateid, st_perstateowner);
 	return lst->st_file->fi_inode == inode;