From: Andrea Arcangeli Date: Tue, 10 Aug 2010 00:19:08 +0000 (-0700) Subject: rmap: always add new vmas at the end X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=26ba0cb63cb8df4e45394227f33c938920b11b88;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git rmap: always add new vmas at the end Make sure to always add new VMAs at the end of the list. This is important so rmap_walk does not miss a VMA that was created during the rmap_walk. The old code got this right most of the time due to luck, but was buggy when anon_vma_prepare reused a mergeable anon_vma. Signed-off-by: Andrea Arcangeli Signed-off-by: Rik van Riel Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/mm/rmap.c b/mm/rmap.c index 07e9814c7a41..dce74a9efdd6 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -147,7 +147,7 @@ int anon_vma_prepare(struct vm_area_struct *vma) avc->anon_vma = anon_vma; avc->vma = vma; list_add(&avc->same_vma, &vma->anon_vma_chain); - list_add(&avc->same_anon_vma, &anon_vma->head); + list_add_tail(&avc->same_anon_vma, &anon_vma->head); allocated = NULL; avc = NULL; }