From: Jesper Juhl <jj@chaosbits.net>
Date: Thu, 6 Jan 2011 10:50:29 +0000 (+0000)
Subject: hamradio: Resolve memory leak due to missing firmware release in add_mcs()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=26877c794407855f65c056d7914b2e72ae9b93b8;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git

hamradio: Resolve memory leak due to missing firmware release in add_mcs()

Failure to release_firmware() in drivers/net/hamradio/yam.c::add_mcs()
causes memory leak.
This patch should fix it.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
index 4e7d1d0a2340..7d9ced0738c5 100644
--- a/drivers/net/hamradio/yam.c
+++ b/drivers/net/hamradio/yam.c
@@ -396,7 +396,7 @@ static unsigned char *add_mcs(unsigned char *bits, int bitrate,
 	while (p) {
 		if (p->bitrate == bitrate) {
 			memcpy(p->bits, bits, YAM_FPGA_SIZE);
-			return p->bits;
+			goto out;
 		}
 		p = p->next;
 	}
@@ -411,7 +411,7 @@ static unsigned char *add_mcs(unsigned char *bits, int bitrate,
 	p->bitrate = bitrate;
 	p->next = yam_data;
 	yam_data = p;
-
+ out:
 	release_firmware(fw);
 	return p->bits;
 }