From: Frans Klaver Date: Wed, 10 Jun 2015 20:38:15 +0000 (+0200) Subject: mtd: core: tone down suggestion that dev.parent should be set X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=260e89a6e0d6dcaccd484cf13a69285c3d22268f;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git mtd: core: tone down suggestion that dev.parent should be set add_mtd_device() has a comment suggesting that the caller should have set dev.parent. This is required to have the parent device symlink show up in sysfs, but not for proper operation of the mtd device itself. Currently we have five drivers registering mtd devices during module initialization, so they don't actually provide a parent device to link to. That means we cannot WARN_ON() here, as it would trigger false positives. Make the comment a bit less firm in its assertion that dev.parent should be set. Signed-off-by: Frans Klaver Signed-off-by: Brian Norris --- diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index 8598e3b783fe..ac280eef5ae8 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -430,7 +430,7 @@ int add_mtd_device(struct mtd_info *mtd) } /* Caller should have set dev.parent to match the - * physical device. + * physical device, if appropriate. */ mtd->dev.type = &mtd_devtype; mtd->dev.class = &mtd_class;