From: Will Deacon Date: Mon, 19 Feb 2018 14:55:55 +0000 (+0000) Subject: fs: dcache: Use READ_ONCE when accessing i_dir_seq X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=2565b271aed0199f5ff977429486e3b59e68e708;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git fs: dcache: Use READ_ONCE when accessing i_dir_seq [ Upstream commit 8cc07c808c9d595e81cbe5aad419b7769eb2e5c9 ] i_dir_seq is subject to concurrent modification by a cmpxchg or store-release operation, so ensure that the relaxed access in d_alloc_parallel uses READ_ONCE. Reported-by: Peter Zijlstra Signed-off-by: Will Deacon Signed-off-by: Al Viro Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/dcache.c b/fs/dcache.c index e0d400c3005d..5f31a93150d1 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -2510,7 +2510,7 @@ retry: } hlist_bl_lock(b); - if (unlikely(parent->d_inode->i_dir_seq != seq)) { + if (unlikely(READ_ONCE(parent->d_inode->i_dir_seq) != seq)) { hlist_bl_unlock(b); rcu_read_unlock(); goto retry;