From: wzt.wzt@gmail.com <wzt.wzt@gmail.com>
Date: Wed, 10 Nov 2010 03:31:55 +0000 (+0800)
Subject: APPARMOR: Fix memory leak of alloc_namespace()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=246c3fb16b08193837a8009ff15ef6908534ba71;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git

APPARMOR: Fix memory leak of alloc_namespace()

policy->name is a substring of policy->hname, if prefix is not NULL, it will
allocted strlen(prefix) + strlen(name) + 3 bytes to policy->hname in policy_init().
use kzfree(ns->base.name) will casue memory leak if alloc_namespace() failed.

Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Signed-off-by: James Morris <jmorris@namei.org>
---

diff --git a/security/apparmor/policy.c b/security/apparmor/policy.c
index 52cc865f1464..4f0eadee78b8 100644
--- a/security/apparmor/policy.c
+++ b/security/apparmor/policy.c
@@ -306,7 +306,7 @@ static struct aa_namespace *alloc_namespace(const char *prefix,
 	return ns;
 
 fail_unconfined:
-	kzfree(ns->base.name);
+	kzfree(ns->base.hname);
 fail_ns:
 	kzfree(ns);
 	return NULL;