From: Dan Carpenter Date: Wed, 13 Jul 2016 10:11:19 +0000 (+0300) Subject: dsp56k: prevent a harmless underflow X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=241903641111803807c90016866d88d7ef8c9347;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git dsp56k: prevent a harmless underflow There is a mistake here where we don't allow "len" to be zero but we allow negative lengths. It's basically harmless in this case, but the underflow makes my static checker complain. Signed-off-by: Dan Carpenter Reviewed-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/char/dsp56k.c b/drivers/char/dsp56k.c index 8bf70e8c3f79..50aa9ba91f25 100644 --- a/drivers/char/dsp56k.c +++ b/drivers/char/dsp56k.c @@ -325,7 +325,7 @@ static long dsp56k_ioctl(struct file *file, unsigned int cmd, if(get_user(bin, &binary->bin) < 0) return -EFAULT; - if (len == 0) { + if (len <= 0) { return -EINVAL; /* nothing to upload?!? */ } if (len > DSP56K_MAX_BINARY_LENGTH) {