From: Jens Wiklander <jens.wiklander@linaro.org>
Date: Mon, 9 Oct 2017 09:11:49 +0000 (+0200)
Subject: optee: fix invalid of_node_put() in optee_driver_init()
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=23b22186b27f6f16cddc69fd12b607c71de6451f;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git

optee: fix invalid of_node_put() in optee_driver_init()

commit f044113113dd95ba73916bde10e804d3cdfa2662 upstream.

The first node supplied to of_find_matching_node() has its reference
counter decreased as part of call to that function. In optee_driver_init()
after calling of_find_matching_node() it's invalid to call of_node_put() on
the supplied node again.

So remove the invalid call to of_node_put().

Reported-by: Alex Shi <alex.shi@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Cc: <andi@linux-stable.l.notmuch.email>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index 7952357df9c8..edb6e4e9ef3a 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers/tee/optee/core.c
@@ -590,7 +590,6 @@ static int __init optee_driver_init(void)
 		return -ENODEV;
 
 	np = of_find_matching_node(fw_np, optee_match);
-	of_node_put(fw_np);
 	if (!np)
 		return -ENODEV;