From: Krzysztof Kozlowski Date: Fri, 21 Mar 2014 12:18:17 +0000 (+0100) Subject: clk: s2mps11: Fix possible NULL pointer dereference X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=238e14055da87d0d012257788e39fe0df3a82226;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git clk: s2mps11: Fix possible NULL pointer dereference If parent device does not have of_node set the s2mps11_clk_parse_dt() returned NULL. This NULL was later passed to of_clk_add_provider() which dereferenced it in pr_debug() call. Signed-off-by: Krzysztof Kozlowski Cc: Signed-off-by: Mike Turquette --- diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c index f4c1f0881b6c..10e66e90d81c 100644 --- a/drivers/clk/clk-s2mps11.c +++ b/drivers/clk/clk-s2mps11.c @@ -132,7 +132,7 @@ static struct device_node *s2mps11_clk_parse_dt(struct platform_device *pdev) int i; if (!iodev->dev->of_node) - return NULL; + return ERR_PTR(-EINVAL); clk_np = of_find_node_by_name(iodev->dev->of_node, "clocks"); if (!clk_np) {