From: Purna Chandra Mandal Date: Fri, 13 May 2016 08:42:53 +0000 (+0530) Subject: spi: pic32-sqi: Fix linker error, undefined reference to `bad_dma_ops'. X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=21825ff11d683fa2fc0f5668cc2ec0a0652ee64b;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git spi: pic32-sqi: Fix linker error, undefined reference to `bad_dma_ops'. Even if DMA support is disabled code using DMA mapping APIs compiles fine, but fails in linking. ------- drivers/built-in.o: In function `ring_desc_ring_free': spi-pic32-sqi.c:(.text+0x2cfbe0): undefined reference to `bad_dma_ops' spi-pic32-sqi.c:(.text+0x2cfbe4): undefined reference to `bad_dma_ops' drivers/built-in.o: In function `pic32_sqi_probe': spi-pic32-sqi.c:(.text+0x2cfe48): undefined reference to `bad_dma_ops' spi-pic32-sqi.c:(.text+0x2cfeb0): undefined reference to `bad_dma_ops' spi-pic32-sqi.c:(.text+0x2cff38): undefined reference to `bad_dma_ops' -------- Correct dependency by adding 'depends on HAS_DMA' in Kconfig. Signed-off-by: Purna Chandra Mandal Signed-off-by: Mark Brown --- diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 281ed5da4832..0f507552ed3e 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -445,6 +445,7 @@ config SPI_PIC32 config SPI_PIC32_SQI tristate "Microchip PIC32 Quad SPI driver" depends on MACH_PIC32 || COMPILE_TEST + depends on HAS_DMA help SPI driver for PIC32 Quad SPI controller.