From: Colin Ian King <colin.king@canonical.com>
Date: Tue, 7 Feb 2017 10:56:38 +0000 (+0000)
Subject: net: bridge: remove redundant check to see if err is set
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=1f02b5f42f53af516c4f5f747390e66d7a8f0bfe;p=GitHub%2Fmoto-9609%2Fandroid_kernel_motorola_exynos9610.git

net: bridge: remove redundant check to see if err is set

The error check on err is redundant as it is being checked
previously each time it has been updated.  Remove this redundant
check.

Detected with CoverityScan, CID#140030("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 1cbdc5b96aa7..a8f6acd23e30 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -612,9 +612,6 @@ static int br_afspec(struct net_bridge *br,
 				return err;
 			break;
 		}
-
-		if (err)
-			return err;
 	}
 
 	return err;