From: Eric Anholt Date: Fri, 28 Apr 2017 22:42:22 +0000 (-0700) Subject: drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=1e70bdcbeb210afedc8f3103ff4fe295c2fa9fc1;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. There's no sense in having an fbdev if there's no display, since connectors don't get hotplugged to this hardware. On Cygnus we were getting a dmesg error from passing in num_connectors (0), when that argument is supposed to be the maximum number of cloned connectors per CRTC (1). Signed-off-by: Eric Anholt Reviewed-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/20170428224223.21904-2-eric@anholt.net --- diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index ad7925a9e0ea..237a504f11f0 100644 --- a/drivers/gpu/drm/vc4/vc4_kms.c +++ b/drivers/gpu/drm/vc4/vc4_kms.c @@ -230,10 +230,12 @@ int vc4_kms_load(struct drm_device *dev) drm_mode_config_reset(dev); - vc4->fbdev = drm_fbdev_cma_init(dev, 32, - dev->mode_config.num_connector); - if (IS_ERR(vc4->fbdev)) - vc4->fbdev = NULL; + if (dev->mode_config.num_connector) { + vc4->fbdev = drm_fbdev_cma_init(dev, 32, + dev->mode_config.num_connector); + if (IS_ERR(vc4->fbdev)) + vc4->fbdev = NULL; + } drm_kms_helper_poll_init(dev);