From: Tilman Schmidt Date: Sat, 11 Oct 2014 11:46:29 +0000 (+0200) Subject: isdn/gigaset: missing break in do_facility_req X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=1bdc07ebabefd19b56d1d36584a401ff6085fa71;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git isdn/gigaset: missing break in do_facility_req If we take the unsupported supplementary service notification mask path, we end up falling through and overwriting the error code. Insert a break statement to skip the remainder of the switch case and proceed to sending the reply message. Spotted with Coverity. Reported-by: Dave Jones Signed-off-by: Tilman Schmidt Signed-off-by: David S. Miller --- diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c index 3286903a95d2..a2eabe97deea 100644 --- a/drivers/isdn/gigaset/capi.c +++ b/drivers/isdn/gigaset/capi.c @@ -1180,6 +1180,7 @@ static void do_facility_req(struct gigaset_capi_ctr *iif, confparam[3] = 2; /* length */ capimsg_setu16(confparam, 4, CapiSupplementaryServiceNotSupported); + break; } info = CapiSuccess; confparam[3] = 2; /* length */