From: Mathieu Maret Date: Tue, 15 Apr 2014 10:03:05 +0000 (+0200) Subject: staging: binder: add __user annotation in binder.c X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=1b4ce188c6c54bda40d8165c1f5fa41949b451d5;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git staging: binder: add __user annotation in binder.c Add __user to binder_version to correct sparse warning. Reduce line size to fit to coding style. Change-Id: I8694fb5a082721c69d1596b2853c5d4899f6536b Signed-off-by: Mathieu Maret Signed-off-by: Greg Kroah-Hartman Git-commit: 9c5197b7a50ae6a323b0281826fb36ab6389d74e Git-repo: https://android.googlesource.com/kernel/common.git Signed-off-by: Ian Maund --- diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 9d451e23d97..669fbd90ff8 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android/binder.c @@ -2715,16 +2715,20 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) binder_free_thread(proc, thread); thread = NULL; break; - case BINDER_VERSION: + case BINDER_VERSION: { + struct binder_version __user *ver = ubuf; + if (size != sizeof(struct binder_version)) { ret = -EINVAL; goto err; } - if (put_user(BINDER_CURRENT_PROTOCOL_VERSION, &((struct binder_version *)ubuf)->protocol_version)) { + if (put_user(BINDER_CURRENT_PROTOCOL_VERSION, + &ver->protocol_version)) { ret = -EINVAL; goto err; } break; + } default: ret = -EINVAL; goto err;