From: Patrick McHardy <kaber@trash.net>
Date: Thu, 23 Mar 2006 09:16:48 +0000 (-0800)
Subject: [NET_SCHED]: cls_u32: remove unnecessary NULL-ptr check
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=1ae39a430b692552e5aceb63fa35ce95fcbadc6a;p=GitHub%2Fmt8127%2Fandroid_kernel_alcatel_ttab.git

[NET_SCHED]: cls_u32: remove unnecessary NULL-ptr check

In both cases n can't be NULL without crashing anyway.

Coverity #78

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index 2b670479dde1..78e052591fa9 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -347,8 +347,7 @@ static int u32_destroy_key(struct tcf_proto *tp, struct tc_u_knode *n)
 	if (n->ht_down)
 		n->ht_down->refcnt--;
 #ifdef CONFIG_CLS_U32_PERF
-	if (n)
-		kfree(n->pf);
+	kfree(n->pf);
 #endif
 	kfree(n);
 	return 0;
@@ -680,8 +679,7 @@ static int u32_change(struct tcf_proto *tp, unsigned long base, u32 handle,
 		return 0;
 	}
 #ifdef CONFIG_CLS_U32_PERF
-	if (n)
-		kfree(n->pf);
+	kfree(n->pf);
 #endif
 	kfree(n);
 	return err;