From: Tim Düsterhus <duesterhus@woltlab.com>
Date: Wed, 8 Jul 2020 12:50:28 +0000 (+0200)
Subject: Fix parsing of packageName / packageDescription in PackageArchive
X-Git-Tag: 5.4.0_Alpha_1~386
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=1853d5dd66ca6a03be258ff6535f75aad21ab540;p=GitHub%2FWoltLab%2FWCF.git

Fix parsing of packageName / packageDescription in PackageArchive

Previously a lowercase key remained in the returned array.
---

diff --git a/wcfsetup/install/files/lib/system/package/PackageArchive.class.php b/wcfsetup/install/files/lib/system/package/PackageArchive.class.php
index ba4c94fc11..991d25e328 100644
--- a/wcfsetup/install/files/lib/system/package/PackageArchive.class.php
+++ b/wcfsetup/install/files/lib/system/package/PackageArchive.class.php
@@ -211,15 +211,6 @@ class PackageArchive
                 case 'packagedescription':
                 case 'readme':
                 case 'license':
-                    if (!isset($this->packageInfo[$element->tagName])) {
-                        $this->packageInfo[$element->tagName] = [];
-                    }
-
-                    $languageCode = 'default';
-                    if ($element->hasAttribute('language')) {
-                        $languageCode = $element->getAttribute('language');
-                    }
-
                     // fix case-sensitive names
                     $name = $element->tagName;
                     if ($name == 'packagename') {
@@ -228,6 +219,15 @@ class PackageArchive
                         $name = 'packageDescription';
                     }
 
+                    if (!isset($this->packageInfo[$name])) {
+                        $this->packageInfo[$name] = [];
+                    }
+
+                    $languageCode = 'default';
+                    if ($element->hasAttribute('language')) {
+                        $languageCode = $element->getAttribute('language');
+                    }
+
                     $this->packageInfo[$name][$languageCode] = $element->nodeValue;
                     break;