From: Matthias Schmidt <gravatronics@live.com>
Date: Sat, 17 Nov 2018 08:50:34 +0000 (+0100)
Subject: Fix PIP GUI-related bbcode issues
X-Git-Tag: 5.2.0_Alpha_1~549
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=17e872b58631ddc13599f49db94b6b8a633e82d2;p=GitHub%2FWoltLab%2FWCF.git

Fix PIP GUI-related bbcode issues

See #2545
---

diff --git a/wcfsetup/install/files/lib/system/package/plugin/BBCodePackageInstallationPlugin.class.php b/wcfsetup/install/files/lib/system/package/plugin/BBCodePackageInstallationPlugin.class.php
index 139d3e61b6..37e01027c6 100644
--- a/wcfsetup/install/files/lib/system/package/plugin/BBCodePackageInstallationPlugin.class.php
+++ b/wcfsetup/install/files/lib/system/package/plugin/BBCodePackageInstallationPlugin.class.php
@@ -276,7 +276,7 @@ class BBCodePackageInstallationPlugin extends AbstractXMLPackageInstallationPlug
 		$attributes = $element->getElementsByTagName('attributes')->item(0);
 		if ($attributes !== null) {
 			$optionalAttributeElements = [
-				$saveData ? 'html' : 'attributeHtml' => 'html',
+				'html' => 'attributeHtml',
 				'required' => 'required',
 				'usetext' => $saveData ? 'usetext' : 'useText',
 				'validationpattern' => $saveData ? 'validationpattern' : 'validationPattern'
@@ -525,11 +525,11 @@ class BBCodePackageInstallationPlugin extends AbstractXMLPackageInstallationPlug
 			$bbcode,
 			[
 				'classname' => '',
-				'htmlclose' => [
+				'htmlopen' => [
 					'cdata' => true,
 					'defaultValue' => ''
 				],
-				'htmlopen' => [
+				'htmlclose' => [
 					'cdata' => true,
 					'defaultValue' => ''
 				],
@@ -549,9 +549,9 @@ class BBCodePackageInstallationPlugin extends AbstractXMLPackageInstallationPlug
 				$attribute = $document->createElement('attribute');
 				$attribute->setAttribute('name', (string) $attributeNumber);
 				
-				if (!empty($attributeData['html'])) {
+				if (!empty($attributeData['attributeHtml'])) {
 					$html = $document->createElement('html');
-					$html->appendChild($document->createCDATASection($attributeData['html']));
+					$html->appendChild($document->createCDATASection($attributeData['attributeHtml']));
 					$attribute->appendChild($html);
 				}
 				if (!empty($attributeData['validationPattern'])) {