From: Masahiro Yamada Date: Fri, 4 Aug 2017 02:59:32 +0000 (+0900) Subject: pinctrl: check ops->pin_config_set in pinconf_set_config() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=17a512486bab646109770f6577396810e83acfbb;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git pinctrl: check ops->pin_config_set in pinconf_set_config() pinconf_set_config() is called by pinctrl_gpio_set_config(). If a GPIO driver is backed by a pinctrl driver and it does not support .pin_config_set() hook, it causes NULL pointer dereference. Fixes: 15381bc7c7f5 ("pinctrl: Allow configuration of pins from gpiolib based drivers") Signed-off-by: Masahiro Yamada Acked-by: Mika Westerberg Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c index 92f363793f35..d3fe14394b73 100644 --- a/drivers/pinctrl/pinconf.c +++ b/drivers/pinctrl/pinconf.c @@ -205,7 +205,7 @@ int pinconf_set_config(struct pinctrl_dev *pctldev, unsigned pin, const struct pinconf_ops *ops; ops = pctldev->desc->confops; - if (!ops) + if (!ops || !ops->pin_config_set) return -ENOTSUPP; return ops->pin_config_set(pctldev, pin, configs, nconfigs);