From: Markus Elfring Date: Mon, 24 Nov 2014 21:58:48 +0000 (+0100) Subject: staging: olpc_dcon: Deletion of a check before backlight_device_unregister() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=16ceb7283987d8d7cad260bacf49f4197c625504;p=GitHub%2Fexynos8895%2Fandroid_kernel_samsung_universal8895.git staging: olpc_dcon: Deletion of a check before backlight_device_unregister() The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c index eb83b28b8cd1..6a9a8815477c 100644 --- a/drivers/staging/olpc_dcon/olpc_dcon.c +++ b/drivers/staging/olpc_dcon/olpc_dcon.c @@ -682,8 +682,7 @@ static int dcon_remove(struct i2c_client *client) free_irq(DCON_IRQ, dcon); - if (dcon->bl_dev) - backlight_device_unregister(dcon->bl_dev); + backlight_device_unregister(dcon->bl_dev); if (dcon_device != NULL) platform_device_unregister(dcon_device);