From: Julian Calaby <julian.calaby@gmail.com>
Date: Fri, 3 Dec 2010 17:56:45 +0000 (+0000)
Subject: sparc: prom: Sanitize return value from prom_nbputchar()
X-Git-Tag: MMI-PSA29.97-13-9~21442^2~24
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=154337688bfa970453836e65a27de011aba55331;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

sparc: prom: Sanitize return value from prom_nbputchar()

Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/arch/sparc/prom/console_32.c b/arch/sparc/prom/console_32.c
index 48863108a44c..b05e3db5fa63 100644
--- a/arch/sparc/prom/console_32.c
+++ b/arch/sparc/prom/console_32.c
@@ -27,13 +27,14 @@ static int prom_nbputchar(const char *buf)
 	spin_lock_irqsave(&prom_lock, flags);
 	switch(prom_vers) {
 	case PROM_V0:
-		i = (*(romvec->pv_nbputchar))(*buf);
+		if ((*(romvec->pv_nbputchar))(*buf))
+			i = 1;
 		break;
 	case PROM_V2:
 	case PROM_V3:
 		if ((*(romvec->pv_v2devops).v2_dev_write)(*romvec->pv_v2bootargs.fd_stdout,
 							  buf, 0x1) == 1)
-			i = 0;
+			i = 1;
 		break;
 	default:
 		break;
@@ -47,7 +48,7 @@ void prom_console_write_buf(const char *buf, int len)
 {
 	while (len) {
 		int n = prom_nbputchar(buf);
-		if (n)
+		if (n < 0)
 			continue;
 		len--;
 		buf++;