From: Mauro Carvalho Chehab Date: Fri, 12 Feb 2016 10:07:59 +0000 (-0200) Subject: [media] v4l2-mc: remove the unused sensor var X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=153d41a1d0a47dfd4d773d8b9db192a62f92355e;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git [media] v4l2-mc: remove the unused sensor var This fixes this warning: v4l2-mc.c: In function 'v4l2_mc_create_media_graph': v4l2-mc.c:60:69: warning: variable 'sensor' set but not used [-Wunused-but-set-variable] We could solve it the other way: don't do the second loop for webcams. However, that would fail if a chip would have two sensors plugged. This is not the current case, but it doesn't hurt to be future-safe here, specially since this code runs only once during device probe. So, performance is not an issue here. Reported-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-mc.c index 97b2e1e64d2e..9d79d599d979 100644 --- a/drivers/media/v4l2-core/v4l2-mc.c +++ b/drivers/media/v4l2-core/v4l2-mc.c @@ -96,7 +96,7 @@ int v4l2_mc_create_media_graph(struct media_device *mdev) { struct media_entity *entity; - struct media_entity *if_vid = NULL, *if_aud = NULL, *sensor = NULL; + struct media_entity *if_vid = NULL, *if_aud = NULL; struct media_entity *tuner = NULL, *decoder = NULL; struct media_entity *io_v4l = NULL, *io_vbi = NULL, *io_swradio = NULL; bool is_webcam = false; @@ -130,7 +130,6 @@ int v4l2_mc_create_media_graph(struct media_device *mdev) io_swradio = entity; break; case MEDIA_ENT_F_CAM_SENSOR: - sensor = entity; is_webcam = true; break; }