From: Peter Senna Tschudin Date: Thu, 6 Sep 2012 14:23:58 +0000 (-0300) Subject: [media] drivers/media/platform/blackfin/bfin_capture.c: fix error return code X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=150a1363680b93703883a0d193756d620666031a;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git [media] drivers/media/platform/blackfin/bfin_capture.c: fix error return code Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // Signed-off-by: Peter Senna Tschudin Cc: Scott Jiang Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/blackfin/bfin_capture.c b/drivers/media/platform/blackfin/bfin_capture.c index 1677623d8296..cb2eb26850b1 100644 --- a/drivers/media/platform/blackfin/bfin_capture.c +++ b/drivers/media/platform/blackfin/bfin_capture.c @@ -968,6 +968,7 @@ static int __devinit bcap_probe(struct platform_device *pdev) if (!i2c_adap) { v4l2_err(&bcap_dev->v4l2_dev, "Unable to find i2c adapter\n"); + ret = -ENODEV; goto err_unreg_vdev; }