From: Viresh Kumar Date: Mon, 11 Jan 2016 05:59:06 +0000 (+0530) Subject: greybus: arche-platform: svc_reset_gpio can't be invalid in arche_platform_cleanup() X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=140741ec6384435b1a0f89042a2a6dac8e2eebd2;p=GitHub%2FLineageOS%2Fandroid_kernel_motorola_exynos9610.git greybus: arche-platform: svc_reset_gpio can't be invalid in arche_platform_cleanup() svc_reset_gpio is guaranteed to be valid in arche_platform_cleanup. Drop the useless check. Signed-off-by: Viresh Kumar Reviewed-by: Vaibhav Hiremath Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index 67bbd71ec3d1..93ecd8c8bed7 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -61,9 +61,8 @@ static void unexport_gpios(struct arche_platform_drvdata *arche_pdata) static void arche_platform_cleanup(struct arche_platform_drvdata *arche_pdata) { /* As part of exit, put APB back in reset state */ - if (gpio_is_valid(arche_pdata->svc_reset_gpio)) - svc_reset_onoff(arche_pdata->svc_reset_gpio, - arche_pdata->is_reset_act_hi); + svc_reset_onoff(arche_pdata->svc_reset_gpio, + arche_pdata->is_reset_act_hi); } static int arche_platform_probe(struct platform_device *pdev)