From: Jesper Juhl <jesper.juhl@gmail.com>
Date: Thu, 9 Aug 2007 21:02:36 +0000 (+0200)
Subject: USB: Fix a memory leak in em28xx_usb_probe()
X-Git-Tag: MMI-PSA29.97-13-9~40663^2~21
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=1207cf84f289694ba7ba8eeaa346a0195b3de606;p=GitHub%2FMotorolaMobilityLLC%2Fkernel-slsi.git

USB: Fix a memory leak in em28xx_usb_probe()

If, in em28xx_usb_probe() the memory allocation
	dev->alt_max_pkt_size = kmalloc(32*
						dev->num_alt,GFP_KERNEL);
fails, then we'll bail out and return -ENOMEM.
The problem is that in that case we don't free the storage allocated
to 'dev', thus causing a memory leak.

This patch fixes the leak by freeing 'dev' before we return -ENOMEM.
This fixes Coverity bug #647.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index 2c7b158ce7e1..40307f3f6fe3 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -1772,6 +1772,7 @@ static int em28xx_usb_probe(struct usb_interface *interface,
 	if (dev->alt_max_pkt_size == NULL) {
 		em28xx_errdev("out of memory!\n");
 		em28xx_devused&=~(1<<nr);
+		kfree(dev);
 		return -ENOMEM;
 	}