From: Alexander Ebert <ebert@woltlab.com>
Date: Mon, 21 Dec 2020 17:01:45 +0000 (+0100)
Subject: Incorrect usage of `<div>` inside `<code>`
X-Git-Tag: 5.3.2~21
X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=1149a775c2f68da6b786cf8b9b9f195e58c969bf;p=GitHub%2FWoltLab%2FWCF.git

Incorrect usage of `<div>` inside `<code>`

Fixes #3720
---

diff --git a/com.woltlab.wcf/templates/codeMetaCode.tpl b/com.woltlab.wcf/templates/codeMetaCode.tpl
index 67e183bcaa..35c0c8c4b1 100644
--- a/com.woltlab.wcf/templates/codeMetaCode.tpl
+++ b/com.woltlab.wcf/templates/codeMetaCode.tpl
@@ -10,7 +10,7 @@
 	{assign var='lineNumber' value=$startLineNumber}
 	<pre class="codeBoxCode collapsibleBbcodeOverflow"><code{if $language} class="language-{$language}"{/if}>{foreach from=$content item=line}{*
 		*}{assign var='codeLineID' value='codeLine_'|concat:$lineNumber:'_':$codeID}{*
-		*}<div class="codeBoxLine" id="{$codeLineID}"><a href="{@$__wcf->getAnchor($codeLineID)}" class="lineAnchor" title="{@$lineNumber}"></a><span>{$line}</span></div>{*
+		*}<span class="codeBoxLine" id="{$codeLineID}"><a href="{@$__wcf->getAnchor($codeLineID)}" class="lineAnchor" title="{@$lineNumber}"></a><span>{$line}</span></span>{*
 		*}{assign var='lineNumber' value=$lineNumber+1}{*
 	*}{/foreach}</code></pre>
 	
diff --git a/wcfsetup/install/files/acp/templates/codeMetaCode.tpl b/wcfsetup/install/files/acp/templates/codeMetaCode.tpl
index 67e183bcaa..35c0c8c4b1 100644
--- a/wcfsetup/install/files/acp/templates/codeMetaCode.tpl
+++ b/wcfsetup/install/files/acp/templates/codeMetaCode.tpl
@@ -10,7 +10,7 @@
 	{assign var='lineNumber' value=$startLineNumber}
 	<pre class="codeBoxCode collapsibleBbcodeOverflow"><code{if $language} class="language-{$language}"{/if}>{foreach from=$content item=line}{*
 		*}{assign var='codeLineID' value='codeLine_'|concat:$lineNumber:'_':$codeID}{*
-		*}<div class="codeBoxLine" id="{$codeLineID}"><a href="{@$__wcf->getAnchor($codeLineID)}" class="lineAnchor" title="{@$lineNumber}"></a><span>{$line}</span></div>{*
+		*}<span class="codeBoxLine" id="{$codeLineID}"><a href="{@$__wcf->getAnchor($codeLineID)}" class="lineAnchor" title="{@$lineNumber}"></a><span>{$line}</span></span>{*
 		*}{assign var='lineNumber' value=$lineNumber+1}{*
 	*}{/foreach}</code></pre>
 	
diff --git a/wcfsetup/install/files/style/bbcode/code.scss b/wcfsetup/install/files/style/bbcode/code.scss
index a070d94d2f..008a893917 100644
--- a/wcfsetup/install/files/style/bbcode/code.scss
+++ b/wcfsetup/install/files/style/bbcode/code.scss
@@ -110,6 +110,8 @@
 			font-family: Consolas, 'Courier New', monospace;
 			
 			.codeBoxLine {
+				display: block;
+				
 				> a {
 					margin-left: -7ch;
 					overflow: hidden;