From: NeilBrown Date: Mon, 18 Aug 2014 03:56:38 +0000 (+1000) Subject: md/raid10: fix memory leak when reshaping a RAID10. X-Git-Url: https://git.stricted.de/?a=commitdiff_plain;h=1075d2bdf6334b8373c00978403a69a4d9fdb883;p=GitHub%2FLineageOS%2Fandroid_kernel_samsung_universal7580.git md/raid10: fix memory leak when reshaping a RAID10. commit ce0b0a46955d1bb389684a2605dbcaa990ba0154 upstream. raid10 reshape clears unwanted bits from a bio->bi_flags using a method which, while clumsy, worked until 3.10 when BIO_OWNS_VEC was added. Since then it clears that bit but shouldn't. This results in a memory leak. So change to used the approved method of clearing unwanted bits. As this causes a memory leak which can consume all of memory the fix is suitable for -stable. Fixes: a38352e0ac02dbbd4fa464dc22d1352b5fbd06fd Reported-by: mdraid.pkoch@dfgh.net (Peter Koch) Signed-off-by: NeilBrown Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index d2f8cd332b4..973e26fc18c 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -4398,7 +4398,7 @@ read_more: read_bio->bi_private = r10_bio; read_bio->bi_end_io = end_sync_read; read_bio->bi_rw = READ; - read_bio->bi_flags &= ~(BIO_POOL_MASK - 1); + read_bio->bi_flags &= (~0UL << BIO_RESET_BITS); read_bio->bi_flags |= 1 << BIO_UPTODATE; read_bio->bi_vcnt = 0; read_bio->bi_size = 0;